Issue 7387 - Onboarding shown again after upgrade

mobile/android/base/java/org/mozilla/gecko/BrowserApp.java

Index: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
===================================================================
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -1110,17 +1110,21 @@
             // in the firstrun pane being shown.
             return;
         }
         final StrictMode.ThreadPolicy savedPolicy = StrictMode.allowThreadDiskReads();
 
         try {
             final SharedPreferences prefs = GeckoSharedPrefs.forProfile(this);
 

[jens, 2019/03/28 16:05:28]

Not important at all, but there is a little typo in the comment ('wanna' should
be 'want' or 'wanna do')

[diegocarloslima, 2019/03/28 20:02:13]

Acknowledged.

+            // Mozilla changed the preference name, thus the first run is being showed again after updating. We don't wanna that

[anton, 2019/03/29 04:32:13]

'showed' -> 'shown' ?

+            // See https://issues.adblockplus.org/ticket/7387
+            final String prefFirstRunEnabledBefore57 = GeckoPreferences.NON_PREF_PREFIX + "startpane_enabled";
             if (prefs.getBoolean(FirstrunAnimationContainer.PREF_FIRSTRUN_ENABLED_OLD, true) &&
+                prefs.getBoolean(prefFirstRunEnabledBefore57, true) &&
                 prefs.getBoolean(FirstrunAnimationContainer.PREF_FIRSTRUN_ENABLED, true)) {
                 showSplashScreen = false;
                 if (!Intent.ACTION_VIEW.equals(intent.getAction())) {
                     // Check to see if a distribution has turned off the first run pager.
                     final Distribution distribution = Distribution.getInstance(BrowserApp.this);
                     if (!distribution.shouldWaitForSystemDistribution()) {
                         checkFirstrunInternal();
                     } else {