Noissue - Rename eslint command to lint

Noissue - Rename eslint command to lint

[hub, 2019-04-15 15:02:04]

Dave, you noticed the other day that this was inconsistent with the WebExt.

So here we go.

[Manish Jethani, 2019-04-15 16:50:56]

LGTM

[Sebastian Noack, 2019-04-15 22:16:07]

The README must be updated as well.

[Manish Jethani, 2019-04-16 06:40:29]

On 2019/04/15 22:16:07, Sebastian Noack wrote:
> The README must be updated as well.

It doesn't look like our current README refers to the npm command at all:

https://gitlab.com/eyeo/adblockplus/adblockpluscore/blob/0fce2edbc5a01d962af8...

[Sebastian Noack, 2019-04-16 09:35:39]

On 2019/04/16 06:40:29, Manish Jethani wrote:
> On 2019/04/15 22:16:07, Sebastian Noack wrote:
> > The README must be updated as well.
> 
> It doesn't look like our current README refers to the npm command at all:
> 
>
https://gitlab.com/eyeo/adblockplus/adblockpluscore/blob/0fce2edbc5a01d962af8...

You are right, but that has been a documentation bug, and should be fixed. The
way it's currently documented you'd use the globally installed version of eslint
(or just fails if not available).

[Manish Jethani, 2019-04-16 09:53:17]

On 2019/04/16 09:35:39, Sebastian Noack wrote:
> On 2019/04/16 06:40:29, Manish Jethani wrote:
> > On 2019/04/15 22:16:07, Sebastian Noack wrote:
> > > The README must be updated as well.
> > 
> > It doesn't look like our current README refers to the npm command at all:
> > 
> >
>
https://gitlab.com/eyeo/adblockplus/adblockpluscore/blob/0fce2edbc5a01d962af8...
> 
> You are right, but that has been a documentation bug, and should be fixed. The
> way it's currently documented you'd use the globally installed version of
eslint
> (or just fails if not available).

OK, I agree.

[hub, 2019-04-16 12:17:22]

I didn't update the README because indeed it didn't mention the npm command. 

Let me do that in this patch.

[hub, 2019-04-16 14:45:19]

updated patch with README

[Sebastian Noack, 2019-04-16 22:30:21]

LGTM

[Manish Jethani, 2019-04-17 06:40:21]

We should have mentioned that you need to run `npm install` first the way the
README in adbockpluschrome does, but never mind. We can make an additional
change later.

[Sebastian Noack, 2019-04-17 06:47:57]

On 2019/04/17 06:40:21, Manish Jethani wrote:
> We should have mentioned that you need to run `npm install` first the way the
> README in adbockpluschrome does, but never mind. We can make an additional
> change later.

I was thinking the same but it is actually mentioned further up. But FWIW, I
also prefer the way the README in adblockpluschrome is structured, but changing
that would argiao out of scope here.

[Manish Jethani, 2019-04-17 07:02:24]

On 2019/04/17 06:47:57, Sebastian Noack wrote:
> On 2019/04/17 06:40:21, Manish Jethani wrote:
> > We should have mentioned that you need to run `npm install` first the way
the
> > README in adbockpluschrome does, but never mind. We can make an additional
> > change later.
> 
> I was thinking the same but it is actually mentioned further up. But FWIW, I
> also prefer the way the README in adblockpluschrome is structured, but
changing
> that would argiao out of scope here.

Yeah, the further up is a separate section about testing only, this is a section
at the same level about linting.