Fixed #4 - Disable $rewrite option for all but internal redirect

Fixed #4 - Disable $rewrite option for all but internal redirect

[hub, 2019-04-16 13:44:27]

Grafted to next. A couple of conflicts where resolved.

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:705: value = new RegExp(filterToRegExp(pattern));
There was a conflict here (removal of the last argument of new RegExp() netween
master and next)

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:963: rewrite = value.substring("abp-resource:".length);
There was another conflict here. We changed from substr() to substring().

[Manish Jethani, 2019-04-16 13:49:28]

On 2019/04/16 13:44:27, hub wrote:
> Grafted to next. A couple of conflicts where resolved.

Can you confirm that there were no conflicts in the test file?

[Manish Jethani, 2019-04-16 13:49:41]

On 2019/04/16 13:49:28, Manish Jethani wrote:
> On 2019/04/16 13:44:27, hub wrote:
> > Grafted to next. A couple of conflicts where resolved.
> 
> Can you confirm that there were no conflicts in the test file?

I'm asking so I don't have to look at it again :)

[Manish Jethani, 2019-04-16 13:54:06]

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:1060: *   URL. e.g. if the value of the
<code>rewrite</code> parameter is
We forgot this in master but let's do it here: $rewrite option

[Manish Jethani, 2019-04-16 14:06:23]

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:705: value = new RegExp(filterToRegExp(pattern));
On 2019/04/16 13:44:27, hub wrote:
> There was a conflict here (removal of the last argument of new RegExp()
netween
> master and next)

Acknowledged.

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:963: rewrite = value.substring("abp-resource:".length);
On 2019/04/16 13:44:27, hub wrote:
> There was another conflict here. We changed from substr() to substring().

Acknowledged.

[hub, 2019-04-16 14:07:46]

On 2019/04/16 13:49:41, Manish Jethani wrote:
> On 2019/04/16 13:49:28, Manish Jethani wrote:
> > On 2019/04/16 13:44:27, hub wrote:
> > > Grafted to next. A couple of conflicts where resolved.
> > 
> > Can you confirm that there were no conflicts in the test file?
> 
> I'm asking so I don't have to look at it again :)

Only in the lib/filterClasses.js file.

[hub, 2019-04-16 14:08:40]

updated patch

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30046558/diff/30046559/lib/filterClasses.j...
lib/filterClasses.js:1060: *   URL. e.g. if the value of the
<code>rewrite</code> parameter is
On 2019/04/16 13:54:06, Manish Jethani wrote:
> We forgot this in master but let's do it here: $rewrite option

The function docs didn't get that fix. Doing both.

[Manish Jethani, 2019-04-16 14:12:23]

LGTM