Issue 30046562: Issue 7458 - Duplicate entries for EasyPrivacy and Fanboy's Social Blocking List

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30046562: Issue 7458 - Duplicate entries for EasyPrivacy and Fanboy's Social Blocking List

Created:
April 16, 2019, 2:06 p.m. by diegocarloslima

Modified:
April 17, 2019, 9:46 a.m.

Reviewers:
anton, jens

Visibility:
Public.

Description

Issue 7458 - Duplicate entries for EasyPrivacy and Fanboy's Social Blocking List

Patch Set 1 #

Total comments: 3

Created: April 16, 2019, 2:06 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -40 lines)			Patch
	M	mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java	View		3 chunks	+32 lines, -39 lines	2 comments	Download
	M	mobile/android/base/java/org/adblockplus/browser/SubscriptionPreferenceCategory.java	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jens

https://codereview.adblockplus.org/30046562/diff/30046563/mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java File mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java (right): https://codereview.adblockplus.org/30046562/diff/30046563/mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java#newcode83 mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:83: if(!BUILTIN_URLS.contains(s.url)) The white space after the if is missing ...

April 17, 2019, 9:39 a.m. (2019-04-17 09:39:22 UTC) #2

anton

April 17, 2019, 9:46 a.m. (2019-04-17 09:46:35 UTC) #3

https://codereview.adblockplus.org/30046562/diff/30046563/mobile/android/base...
File
mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java
(right):

https://codereview.adblockplus.org/30046562/diff/30046563/mobile/android/base...
mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:50:
"https://easylist-downloads.adblockplus.org/easyprivacy.txt",
the order of `BUILTIN_URLS` should be consistent to `BUILTIN_TITLES`.
It may be unclear without looking into how they are used.

So i'd suggest to either add note here (that order should be consistent) or
use `List<Pair>` where pair has `id` and `url` fields.

Expand All Messages | Collapse All Messages