Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4526994515558400: Fixed request type for sub frames on Safari (Closed)

Created:
Dec. 20, 2013, 9:35 a.m. by Sebastian Noack
Modified:
Jan. 15, 2014, 4:15 p.m.
Visibility:
Public.

Description

* Frames were mapped to "frame", but it has to be "sub_frame". * Also the code uses localName instead of nodeName now.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M safari/ext/content.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
* Frames were mapped to "frame", but it has to be "sub_frame". * Also the ...
Dec. 20, 2013, 9:38 a.m. (2013-12-20 09:38:57 UTC) #1
Wladimir Palant
Jan. 15, 2014, 3:51 p.m. (2014-01-15 15:51:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld