Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 4578638519336960: Issue 1296 - Add SetUpdateAvailableCallback (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Felix Dahlke
Modified:
5 years, 5 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1296 - Add SetUpdateAvailableCallback

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix typo, only invoke callback when the updater passes a URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -10 lines) Patch
M include/AdblockPlus/FilterEngine.h View 1 4 chunks +30 lines, -8 lines 0 comments Download
M src/FilterEngine.cpp View 1 2 chunks +24 lines, -2 lines 0 comments Download
M test/FilterEngine.cpp View 2 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
5 years, 5 months ago (2014-09-18 15:13:59 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h#newcode315 include/AdblockPlus/FilterEngine.h:315: * availble or not - to react to updates ...
5 years, 5 months ago (2014-09-18 19:44:16 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h#newcode315 include/AdblockPlus/FilterEngine.h:315: * availble or not - to react to updates ...
5 years, 5 months ago (2014-09-19 02:51:40 UTC) #3
Wladimir Palant
5 years, 5 months ago (2014-09-22 17:44:24 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5