Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4578638519336960: Issue 1296 - Add SetUpdateAvailableCallback (Closed)

Created:
Sept. 18, 2014, 2:54 p.m. by Felix Dahlke
Modified:
Sept. 23, 2014, 8:06 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1296 - Add SetUpdateAvailableCallback

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix typo, only invoke callback when the updater passes a URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -10 lines) Patch
M include/AdblockPlus/FilterEngine.h View 1 4 chunks +30 lines, -8 lines 0 comments Download
M src/FilterEngine.cpp View 1 2 chunks +24 lines, -2 lines 0 comments Download
M test/FilterEngine.cpp View 2 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Sept. 18, 2014, 3:13 p.m. (2014-09-18 15:13:59 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h#newcode315 include/AdblockPlus/FilterEngine.h:315: * availble or not - to react to updates ...
Sept. 18, 2014, 7:44 p.m. (2014-09-18 19:44:16 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): http://codereview.adblockplus.org/4578638519336960/diff/5724160613416960/include/AdblockPlus/FilterEngine.h#newcode315 include/AdblockPlus/FilterEngine.h:315: * availble or not - to react to updates ...
Sept. 19, 2014, 2:51 a.m. (2014-09-19 02:51:40 UTC) #3
Wladimir Palant
Sept. 22, 2014, 5:44 p.m. (2014-09-22 17:44:24 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld