Issue 1390 - Record referrer for download stats

Issue 1390 - Record referrer for download stats

[Sebastian Noack, 2014-09-18 15:50:04]

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
File sitescripts/stats/test/logprocessor.py (right):

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our
strings are non-Unicode.
Why don't you just use unicode literals above?

[Wladimir Palant, 2014-09-18 18:42:50]

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
File sitescripts/stats/test/logprocessor.py (right):

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our
strings are non-Unicode.
On 2014/09/18 15:50:04, Sebastian Noack wrote:
> Why don't you just use unicode literals above?

Because I don't know which one will use Unicode - it seems pretty random. I
don't know why parse_query returns Unicode for some parameters and not others,
but I'm pretty sure that this test passed before.

[Sebastian Noack, 2014-09-19 09:48:42]

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
File sitescripts/stats/test/logprocessor.py (right):

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our
strings are non-Unicode.
On 2014/09/18 18:42:50, Wladimir Palant wrote:
> On 2014/09/18 15:50:04, Sebastian Noack wrote:
> > Why don't you just use unicode literals above?
> 
> Because I don't know which one will use Unicode - it seems pretty random. I
> don't know why parse_query returns Unicode for some parameters and not others,
> but I'm pretty sure that this test passed before.

According to my tests it doesn't. All strings in the result are plain strings
and all tests pass for me without this hack.

[Wladimir Palant, 2014-09-22 10:39:04]

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
File sitescripts/stats/test/logprocessor.py (right):

http://codereview.adblockplus.org/4635035198029824/diff/5629499534213120/site...
sitescripts/stats/test/logprocessor.py:617: # different, make sure that all our
strings are non-Unicode.
On 2014/09/19 09:48:42, Sebastian Noack wrote:
> According to my tests it doesn't. All strings in the result are plain strings
> and all tests pass for me without this hack.

For some reason I cannot reproduce it any longer, so I removed that hack. If
that issue ever comes back we can still revisit it.

[Sebastian Noack, 2014-09-22 10:39:39]

LGTM