Issue 4652755411009536: Issue #1832 - Updated public suffixes to account for registration of the new ".uk" domains.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4652755411009536: Issue #1832 - Updated public suffixes to account for registration of the new ".uk" domains. (Closed)

Created:
Jan. 20, 2015, 1:13 p.m. by kzar

Modified:
Jan. 21, 2015, 10:32 a.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue #1832 - Updated public suffixes to account for registration of the new ".uk" domains.

Patch Set 1 #

Created: Jan. 20, 2015, 1:13 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	lib/publicSuffixList.js	View		1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

I think there should be an issue for this. And another issue (that can be ...

Jan. 20, 2015, 1:21 p.m. (2015-01-20 13:21:06 UTC) #2

kzar

Jan. 20, 2015, 1:45 p.m. (2015-01-20 13:45:32 UTC) #4

On 2015/01/20 13:39:33, Sebastian Noack wrote:
> LGTM

Thanks, just had a go at writing the issue for the conversion script as well.
(Might need some work though) https://issues.adblockplus.org/ticket/1834

Expand All Messages | Collapse All Messages