Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4660775054475264: Issue #1222 - make sure the installer version is set correctly (Closed)

Created:
Nov. 27, 2014, 1:15 a.m. by Oleksandr
Modified:
Nov. 27, 2014, 9:46 a.m.
Reviewers:
Felix Dahlke
CC:
Eric
Visibility:
Public.

Description

Since makefile triggers rebuilding of installer solutions, we need to pass parameter there, not in build_release.py

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build_release.py View 1 chunk +0 lines, -1 line 0 comments Download
M installer/Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Oleksandr
Nov. 27, 2014, 1:19 a.m. (2014-11-27 01:19:34 UTC) #1
Felix Dahlke
Nov. 27, 2014, 9:29 a.m. (2014-11-27 09:29:44 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld