Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: safari/include.youtube.js

Issue 4663448277352448: Disable history API on YouTube in order to block ads in subsequent videos (Closed)
Left Patch Set: Created Feb. 22, 2014, 5:28 p.m.
Right Patch Set: Addressed comments Created Feb. 24, 2014, 2:26 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 if (value != newValue) 54 if (value != newValue)
55 { 55 {
56 param.setAttribute("value", newValue); 56 param.setAttribute("value", newValue);
57 flashvarsChanged = true; 57 flashvarsChanged = true;
58 } 58 }
59 } 59 }
60 } 60 }
61 61
62 if (flashvarsChanged) 62 if (flashvarsChanged)
63 player.parentNode.replaceChild(newPlayer, player); 63 player.parentNode.replaceChild(newPlayer, player);
64
65 // if history.pushState is available, YouTube uses the history API
66 // when navigation from one video to another, and tells the flash
67 // player with JavaScript which video and which ads to show next,
68 // bypassing our flashvars rewrite code. So we disable
69 // history.pushState on pages with YouTube's flash player.
70 document.location.href = "javascript:void(history.pushState = undefined);";
64 } 71 }
65 72
66 var deferred = []; 73 var deferred = [];
67 function patchPlayerDeferred(player) 74 function patchPlayerDeferred(player)
68 { 75 {
69 deferred.push(player); 76 deferred.push(player);
70 } 77 }
71 78
72 var onBeforeLoadYoutubeVideo = patchPlayerDeferred; 79 var onBeforeLoadYoutubeVideo = patchPlayerDeferred;
73 function onBeforeLoad(event) 80 function onBeforeLoad(event)
74 { 81 {
75 if ((event.target.localName == "object" || event.target.localName == "embed" ) && /:\/\/[^\/]*\.ytimg\.com\//.test(event.url)) 82 if ((event.target.localName == "object" || event.target.localName == "embed" ) && /:\/\/[^\/]*\.ytimg\.com\//.test(event.url))
76 onBeforeLoadYoutubeVideo(event.target); 83 onBeforeLoadYoutubeVideo(event.target);
77 } 84 }
78 85
79 ext.backgroundPage.sendMessage({type: "get-domain-enabled-state"}, function(re sponse) 86 ext.backgroundPage.sendMessage({type: "get-domain-enabled-state"}, function(re sponse)
80 { 87 {
81 if (response.enabled) 88 if (response.enabled)
82 { 89 {
83 deferred.forEach(patchPlayer); 90 deferred.forEach(patchPlayer);
84 onBeforeLoadYoutubeVideo = patchPlayer; 91 onBeforeLoadYoutubeVideo = patchPlayer;
85 } 92 }
86 else 93 else
87 document.removeEventListener("beforeload", onBeforeLoad); 94 document.removeEventListener("beforeload", onBeforeLoad);
88 }); 95 });
89 96
90 document.addEventListener("beforeload", onBeforeLoad, true); 97 document.addEventListener("beforeload", onBeforeLoad, true);
91
92 // if history.pushState is available, YouTube uses the history API
93 // when navigation from one video to another, and tells the flash player
94 // with JavaScript which video and which ads to show next, bypassing
95 // our flashvars rewrite code. So we disable history.pushState on YouTube.
96 var script = document.createElement("script");
97 script.type = "application/javascript";
98 script.textContent = "history.pushState = undefined;";
99 document.documentElement.appendChild(script);
100 })(); 98 })();
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld