Disable history API on YouTube in order to block ads in subsequent videos

Video ads on YouTube are blocked by rewriting the flashvars used to configure the in-video ads. However when you click on another video, the flash player is told via JavaScript which video and which ads to show next, bypassing our flashvars rewrite code.

However YouTube can only do that when history.pushState is available. Otherwise it navigates to the URL of the next video, where the player is loaded and the flashvars can be rewritten again.

So I have disabled history.pushState for youtube.com, in order to block ads also in subsequent YouTube videos.

[Felix Dahlke, 2014-02-24 12:30:25]

LGTM.

It's a hack, but one that most users shouldn't notice, thanks to graceful
degredation. And it fixes a fairly annoying issue.

[Wladimir Palant, 2014-02-24 13:15:03]

This is still a hack but really as safe as it goes, nice solution.

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
File safari/include.youtube.js (right):

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
safari/include.youtube.js:77: document.documentElement.appendChild(script);
We shouldn't leave this script around, it needs to be removed once it did its
job. The other option would be running location.href =
"javascript:void(history.pushState = undefined);" - this shouldn't leave any
artifacts behind.

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
safari/include.youtube.js:79: pushStateDisabled = true;
Why is this flag necessary? Content scripts should never run twice for the same
page.

[Sebastian Noack, 2014-02-24 14:32:08]

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
File safari/include.youtube.js (right):

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
safari/include.youtube.js:77: document.documentElement.appendChild(script);
On 2014/02/24 13:15:03, Wladimir Palant wrote:
> We shouldn't leave this script around, it needs to be removed once it did its
> job. The other option would be running location.href =
> "javascript:void(history.pushState = undefined);" - this shouldn't leave any
> artifacts behind.

Done.

http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...
safari/include.youtube.js:79: pushStateDisabled = true;
On 2014/02/24 13:15:03, Wladimir Palant wrote:
> Why is this flag necessary? Content scripts should never run twice for the
same
> page.

Yes, but the code runs per player loaded. However now where we don't add a
script tag anymore, I also got rid of that flag.

[Wladimir Palant, 2014-02-24 14:52:47]

LGTM

[Felix Dahlke, 2014-02-24 17:46:12]

Even more LGTM!