Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4695455875203072: Noissue - Fix newline bug in tag attributes (Closed)

Created:
May 7, 2015, 11:17 a.m. by kzar
Modified:
May 7, 2015, 12:04 p.m.
Visibility:
Public.

Description

Noissue - Fix newline bug in tag attributes

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cms/converters.py View 1 chunk +6 lines, -1 line 2 comments Download

Messages

Total messages: 4
kzar
May 7, 2015, 11:18 a.m. (2015-05-07 11:18:45 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/4695455875203072/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/4695455875203072/diff/5629499534213120/cms/converters.py#newcode169 cms/converters.py:169: lambda match: r'<%s%s>%s</%s>' % ( I suppose we use ...
May 7, 2015, 11:24 a.m. (2015-05-07 11:24:12 UTC) #2
kzar
http://codereview.adblockplus.org/4695455875203072/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/4695455875203072/diff/5629499534213120/cms/converters.py#newcode169 cms/converters.py:169: lambda match: r'<%s%s>%s</%s>' % ( On 2015/05/07 11:24:12, Sebastian ...
May 7, 2015, 11:25 a.m. (2015-05-07 11:25:16 UTC) #3
Wladimir Palant
May 7, 2015, 11:39 a.m. (2015-05-07 11:39:25 UTC) #4
LGTM but please say "Noissue" (without whitespace) in the commit message. This
is supposed to be parsed by automated tools.

Powered by Google App Engine
This is Rietveld