Issue 4702358030254080: Unified version number across all platforms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4702358030254080: Unified version number across all platforms (Closed)

Created:
Jan. 6, 2014, 2:43 p.m. by Sebastian Noack

Modified:
Jan. 15, 2014, 4 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

As discussed with Wladimir the Safari build should share the same version number as the Chrome and Opera build.

Patch Set 1 #

Created: Jan. 6, 2014, 2:43 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -2 lines)			Patch
M	metadata.chrome	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	metadata.common	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	metadata.safari	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

LGTM. Note however that a buildtools change is necessary as well. releaseAutomation.py currently uses packager.getMetadataPath(baseDir, ...

Jan. 13, 2014, 12:32 p.m. (2014-01-13 12:32:28 UTC) #2

Sebastian Noack

Jan. 15, 2014, 3:08 p.m. (2014-01-15 15:08:53 UTC) #3

On 2014/01/13 12:32:28, Wladimir Palant wrote:
> LGTM. Note however that a buildtools change is necessary as well.
> releaseAutomation.py currently uses packager.getMetadataPath(baseDir, type) to
> find the metadata file to be changed. This will give metadata.chrome rather
than
> metadata.common however. Using packager.readMetadata(baseDir,
> type).option_source("general", "version") should work here.

See http://codereview.adblockplus.org/6047895316856832/

Expand All Messages | Collapse All Messages