Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4734012065054720: Issue 2634 - Consider alternative URLs for element collapsing (Closed)

Created:
June 7, 2015, 3:09 p.m. by Sebastian Noack
Modified:
June 15, 2015, 7:13 a.m.
Reviewers:
kzar, Wladimir Palant
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 2634 - Consider alternative URLs for element collapsing

Patch Set 1 #

Total comments: 1

Patch Set 2 : Exclude non-HTTP(s) URLs in content script #

Total comments: 2

Patch Set 3 : Consider all URLs for element collapsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -113 lines) Patch
M background.js View 1 2 1 chunk +20 lines, -12 lines 0 comments Download
M include.postload.js View 1 chunk +0 lines, -82 lines 0 comments Download
M include.preload.js View 1 2 1 chunk +101 lines, -4 lines 0 comments Download
M lib/filterComposer.js View 1 1 chunk +11 lines, -15 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
For easier review I did split this change in multiple patch sets. Note that the ...
June 7, 2015, 3:30 p.m. (2015-06-07 15:30:06 UTC) #1
kzar
Think this one should also be checked by someone else but LGTM
June 8, 2015, 12:48 p.m. (2015-06-08 12:48:07 UTC) #2
Wladimir Palant
June 8, 2015, 1:11 p.m. (2015-06-08 13:11:15 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld