Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4762316134416384: Issue 1670 - Removed "Hide placeholders" option from the UI (Firefox) (Closed)

Created:
Dec. 8, 2014, 5:11 p.m. by Sebastian Noack
Modified:
Dec. 11, 2014, 2:50 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1670 - Removed "Hide placeholders" option from the UI

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Removed remaining UI code, updated version check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/content/ui/fennecSettings.xul View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/content/ui/overlay.xul View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/content/ui/settings.xul View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/locale/en-US/overlay.dtd View 1 chunk +0 lines, -1 line 0 comments Download
M lib/ui.js View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
Dec. 8, 2014, 5:12 p.m. (2014-12-08 17:12:11 UTC) #1
Wladimir Palant
LGTM
Dec. 11, 2014, 10:20 a.m. (2014-12-11 10:20:07 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/lib/ui.js File lib/ui.js (right): http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/lib/ui.js#newcode1540 lib/ui.js:1540: setChecked(prefix + "slowcollapse", !Prefs.fastcollapse); Wait, shouldn't this be removed ...
Dec. 11, 2014, 10:23 a.m. (2014-12-11 10:23:14 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/chrome/content/ui/overlay.xul File chrome/content/ui/overlay.xul (right): http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/chrome/content/ui/overlay.xul#newcode89 chrome/content/ui/overlay.xul:89: <command id="abp-command-togglecollapse"/> And what about this?
Dec. 11, 2014, 10:24 a.m. (2014-12-11 10:24:13 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/chrome/content/ui/overlay.xul File chrome/content/ui/overlay.xul (right): http://codereview.adblockplus.org/4762316134416384/diff/5724160613416960/chrome/content/ui/overlay.xul#newcode89 chrome/content/ui/overlay.xul:89: <command id="abp-command-togglecollapse"/> On 2014/12/11 10:24:13, Wladimir Palant wrote: > ...
Dec. 11, 2014, 10:41 a.m. (2014-12-11 10:41:28 UTC) #5
Wladimir Palant
Dec. 11, 2014, 11:11 a.m. (2014-12-11 11:11:41 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld