Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4777306409140224: Issue 2607 - Clear currentVersion on uninstallation (Closed)

Created:
May 29, 2015, 4:32 p.m. by Felix Dahlke
Modified:
May 29, 2015, 11:08 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2607 - Clear currentVersion on uninstallation

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use json.loads rather than re.search #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M packagerGecko.py View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
May 29, 2015, 4:36 p.m. (2015-05-29 16:36:23 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4777306409140224/diff/5629499534213120/packagerGecko.py File packagerGecko.py (right): http://codereview.adblockplus.org/4777306409140224/diff/5629499534213120/packagerGecko.py#newcode242 packagerGecko.py:242: templateData['hasVersionPref'] = re.search(r'"currentVersion":', content) != None It's JSON data ...
May 29, 2015, 6:40 p.m. (2015-05-29 18:40:52 UTC) #2
Felix Dahlke
New patch set. http://codereview.adblockplus.org/4777306409140224/diff/5629499534213120/packagerGecko.py File packagerGecko.py (right): http://codereview.adblockplus.org/4777306409140224/diff/5629499534213120/packagerGecko.py#newcode242 packagerGecko.py:242: templateData['hasVersionPref'] = re.search(r'"currentVersion":', content) != None ...
May 29, 2015, 8:04 p.m. (2015-05-29 20:04:10 UTC) #3
Wladimir Palant
May 29, 2015, 8:14 p.m. (2015-05-29 20:14:08 UTC) #4
Wladimir Palant
May 29, 2015, 8:14 p.m. (2015-05-29 20:14:13 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld