Issue 2607 - Clear currentVersion on uninstallation

packagerGecko.py

Index: packagerGecko.py
===================================================================
--- a/packagerGecko.py
+++ b/packagerGecko.py
@@ -231,9 +231,6 @@
         templateData['hasChromeRequires'] = True
     if name.startswith('lib/') and re.search(r'\bXMLHttpRequest\b', content):
       templateData['hasXMLHttpRequest'] = True
-    if name == 'defaults/prefs.js':
-      if re.search(r'\.currentVersion"', content):
-        templateData['hasVersionPref'] = True
     if not '/' in name or name.startswith('lib/'):
       if re.search(r'(?:^|\s)onShutdown\.', content):
         templateData['hasShutdownHandlers'] = True
@@ -241,6 +238,8 @@
   for name, content in files.iteritems():
     if name == 'chrome.manifest':
       templateData['hasChrome'] = True
+    elif name == 'defaults/prefs.json':
+      templateData['hasVersionPref'] = re.search(r'"currentVersion":', content) != None

[Wladimir Palant, 2015/05/29 18:40:52]

It's JSON data now, we can do better:

templateData['hasVersionPref'] = 'currentVersion' in
json.loads(content).get('defaults', {})

[Felix Dahlke, 2015/05/29 20:04:10]

Seemed a bit over the top to me considering that we also use regex to search xul
files. But it's nice and short here, done.

     elif name.endswith('.js'):
       checkScript(name)
     elif name.endswith('.xul'):