Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 4805711393456128: Remove the Repair button from Programs and Features. Fix the CA. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by Oleksandr
Modified:
5 years, 7 months ago
Reviewers:
Eric
Visibility:
Public.

Description

Remove the Repair button from Programs and Features. Fix the CA.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M installer/src/installer-lib/process.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 1 chunk +0 lines, -8 lines 0 comments Download
M installer/src/msi/custom_WixUI_InstallDir.wxs View 1 chunk +10 lines, -1 line 1 comment Download

Messages

Total messages: 2
Oleksandr
5 years, 7 months ago (2014-06-30 16:29:39 UTC) #1
Eric
5 years, 7 months ago (2014-07-18 16:56:09 UTC) #2
This review has already been committed, but my only concerns are about the text
of a comment.

LGTM

http://codereview.adblockplus.org/4805711393456128/diff/5629499534213120/inst...
File installer/src/msi/custom_WixUI_InstallDir.wxs (right):

http://codereview.adblockplus.org/4805711393456128/diff/5629499534213120/inst...
installer/src/msi/custom_WixUI_InstallDir.wxs:71: This is currently set by the
WiXUI property WIXUI_INSTALLDIR, so it's commented out now.
The comment about "commented out" is no longer true.

The comment about a single feature is true about the the "Modify" button. It's
not true about "Repair". If we're getting rid of Repair, it's for a policy
reason that we ought to document, not because it's redundant.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5