Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4805960266678272: Issue 1244 - Remove unused modules from sitescripts.reports imports (Closed)

Created:
Aug. 14, 2014, 2:44 p.m. by mathias
Modified:
Dec. 10, 2014, 12:53 p.m.
Visibility:
Public.

Description

Stumbled upon this while analyzing dependencies for #240 (https://issues.adblockplus.org/ticket/240). Pretty sure I have not missed anything. Almost sure. Well, "quite confident"... ;)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M sitescripts/reports/bin/mailDigests.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/reports/bin/parseNewReports.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/reports/bin/processReports.py View 1 chunk +1 line, -2 lines 0 comments Download
M sitescripts/reports/bin/updateDigests.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/reports/web/showDigest.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/reports/web/submitReport.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/reports/web/updateReport.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
mathias
Aug. 14, 2014, 2:44 p.m. (2014-08-14 14:44:35 UTC) #1
mathias
On 2014/08/14 14:44:35, matze wrote: Any idea how to test this efficiently? Although they're just ...
Aug. 14, 2014, 2:46 p.m. (2014-08-14 14:46:37 UTC) #2
Felix Dahlke
LGTM from my side, but please add Wladimir as a reviewer. Testing these is tricky ...
Aug. 15, 2014, 4:59 a.m. (2014-08-15 04:59:15 UTC) #3
Wladimir Palant
LGTM, lots of code moved around here and the imports weren't always adapted. However, commits ...
Aug. 18, 2014, 12:21 p.m. (2014-08-18 12:21:23 UTC) #4
mathias
On 2014/08/18 12:21:23, Wladimir Palant wrote: > LGTM, lots of code moved around here and ...
Aug. 18, 2014, 3:45 p.m. (2014-08-18 15:45:01 UTC) #5
aalvz
Nov. 25, 2014, 6:45 p.m. (2014-11-25 18:45:56 UTC) #6
LGTM, the reports can be send without issues and can be seen afterwards. Just as
before

Powered by Google App Engine
This is Rietveld