Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4810150141493248: Issue 122 - Puppet ENC via Hiera (Closed)

Created:
Sept. 8, 2014, 11:56 a.m. by mathias
Modified:
March 17, 2015, 4:28 a.m.
CC:
aalvz, paco
Visibility:
Public.

Description

This is a proof of concept published as a request for comments. It is NOT proposed to be pushed/merged yet.

Patch Set 1 #

Total comments: 24

Patch Set 2 : 112 - Puppet ENC via Hiera #

Total comments: 31

Patch Set 3 : 112 - Puppet ENC via Hiera #

Total comments: 1

Patch Set 4 : 112 - Integrate run.py and monitoring with Hiera #

Patch Set 5 : 112 - Integrate run.py and monitoring with Hiera #

Total comments: 52

Patch Set 6 : Puppet ENC via Hiera #

Total comments: 2

Patch Set 7 : Puppet ENC via Hiera #

Total comments: 33

Patch Set 8 : Puppet ENC via Hiera #

Patch Set 9 : Puppet ENC via Hiera - Without Arrow Alignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -430 lines) Patch
M .hgignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 1 2 3 4 5 6 7 5 chunks +65 lines, -28 lines 0 comments Download
M Vagrantfile View 1 2 3 4 5 6 7 4 chunks +35 lines, -52 lines 0 comments Download
A hiera/hiera.yaml View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A hiera/install_precise.py View 1 2 3 4 5 6 7 1 chunk +103 lines, -0 lines 0 comments Download
A hiera/puppet_node_classifier.rb View 1 2 3 4 5 6 7 1 chunk +90 lines, -0 lines 0 comments Download
A hiera/roles/codereviewserver.yaml View 1 1 chunk +6 lines, -0 lines 0 comments Download
A hiera/roles/intraforumserver.yaml View 1 1 chunk +11 lines, -0 lines 0 comments Download
A hiera/roles/monitoringserver.yaml View 1 2 3 4 5 6 1 chunk +85 lines, -0 lines 0 comments Download
R manifests/codereviewserver.pp View 1 4 5 1 chunk +0 lines, -13 lines 0 comments Download
M manifests/downloadserver.pp View 1 2 chunks +1 line, -4 lines 0 comments Download
M manifests/filtermasterserver.pp View 1 1 chunk +1 line, -4 lines 0 comments Download
M manifests/filterserver.pp View 1 2 chunks +1 line, -4 lines 0 comments Download
R manifests/intraforumserver.pp View 1 4 5 1 chunk +0 lines, -14 lines 0 comments Download
M manifests/issuesserver.pp View 1 2 chunks +1 line, -4 lines 0 comments Download
R manifests/monitoringserver.pp View 1 2 3 4 5 6 7 1 chunk +0 lines, -182 lines 0 comments Download
M manifests/nodes.pp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M manifests/statsserver.pp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M manifests/updateserver.pp View 1 2 chunks +1 line, -4 lines 0 comments Download
M manifests/webserver.pp View 1 2 3 4 5 6 7 2 chunks +1 line, -5 lines 0 comments Download
M modules/base/manifests/init.pp View 1 2 3 4 5 6 7 2 chunks +48 lines, -1 line 0 comments Download
M modules/filtermaster/manifests/init.pp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/nagios/manifests/server.pp View 1 2 3 4 5 6 7 8 3 chunks +40 lines, -3 lines 0 comments Download
A modules/private-stub/hiera/base.yaml View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A modules/private-stub/hiera/hosts.yaml View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A modules/private-stub/hiera/roles/monitoringserver.yaml View 1 2 3 4 5 6 7 8 1 chunk +15 lines, -0 lines 0 comments Download
M modules/statsclient/manifests/init.pp View 1 1 chunk +3 lines, -0 lines 0 comments Download
R modules/statsmaster/files/known_hosts View 1 2 3 4 5 1 chunk +0 lines, -32 lines 0 comments Download
M modules/statsmaster/manifests/init.pp View 1 2 3 4 5 6 7 2 chunks +3 lines, -7 lines 0 comments Download
M run.py View 1 2 3 4 5 6 1 chunk +28 lines, -66 lines 0 comments Download

Messages

Total messages: 31
mathias
Sept. 8, 2014, 11:56 a.m. (2014-09-08 11:56:28 UTC) #1
Wladimir Palant
Looks promising, the most serious issue IMHO is requiring one YAML file per server rather ...
Sept. 9, 2014, 6:15 p.m. (2014-09-09 18:15:06 UTC) #2
mathias
Oct. 8, 2014, 3:02 a.m. (2014-10-08 03:02:09 UTC) #3
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5629499534213120/hiera/environments/production File hiera/environments/production (right): http://codereview.adblockplus.org/4810150141493248/diff/5629499534213120/hiera/environments/production#newcode1 hiera/environments/production:1: ../../modules/private/hiera On 2014/09/09 18:15:06, Wladimir Palant wrote: > Is ...
Oct. 8, 2014, 3:02 a.m. (2014-10-08 03:02:33 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/4810150141493248/diff/5657382461898752/README.md File README.md (right): http://codereview.adblockplus.org/4810150141493248/diff/5657382461898752/README.md#newcode13 README.md:13: *development*, *test* and *production*), whilst others are confidential. Explicitly ...
Nov. 17, 2014, 4:43 p.m. (2014-11-17 16:43:35 UTC) #5
mathias
Nov. 27, 2014, 12:29 a.m. (2014-11-27 00:29:43 UTC) #6
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5657382461898752/README.md File README.md (right): http://codereview.adblockplus.org/4810150141493248/diff/5657382461898752/README.md#newcode13 README.md:13: *development*, *test* and *production*), whilst others are confidential. On ...
Nov. 27, 2014, 12:30 a.m. (2014-11-27 00:30:17 UTC) #7
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5713144022302720/hiera/install-precise.py File hiera/install-precise.py (right): http://codereview.adblockplus.org/4810150141493248/diff/5713144022302720/hiera/install-precise.py#newcode2 hiera/install-precise.py:2: import base64 Just saw I forgot to remove this ...
Nov. 27, 2014, 12:39 a.m. (2014-11-27 00:39:53 UTC) #8
Wladimir Palant
LGTM
Dec. 1, 2014, 12:26 p.m. (2014-12-01 12:26:18 UTC) #9
mathias
Feb. 26, 2015, 5:32 p.m. (2015-02-26 17:32:17 UTC) #10
mathias
Now including the changes in modules/private-stub grmlslslsls!!!
Feb. 26, 2015, 5:59 p.m. (2015-02-26 17:59:27 UTC) #11
paco
On 2015/02/26 17:59:27, matze wrote: > Now including the changes in modules/private-stub grmlslslsls!!! hiera/puppet-node-classifier.rb hiera/install-precise.py ...
Feb. 26, 2015, 6:17 p.m. (2015-02-26 18:17:09 UTC) #12
mathias
On 2015/02/26 18:17:09, paco wrote: > On 2015/02/26 17:59:27, matze wrote: > > Now including ...
Feb. 26, 2015, 6:40 p.m. (2015-02-26 18:40:48 UTC) #13
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5647308616105984/run.py File run.py (right): http://codereview.adblockplus.org/4810150141493248/diff/5647308616105984/run.py#newcode72 run.py:72: or name in item[1]['ip'] While resolving IPs would be ...
Feb. 26, 2015, 6:41 p.m. (2015-02-26 18:41:23 UTC) #14
Felix Dahlke
Since I'm a reviewer now, I took a look at all the changes. (Also added ...
March 3, 2015, 4:43 p.m. (2015-03-03 16:43:32 UTC) #15
Wladimir Palant
Frankly, this is far beyond the point where I can still give it a "looks ...
March 3, 2015, 8 p.m. (2015-03-03 20:00:19 UTC) #16
mathias
RC2, as announced.
March 4, 2015, 12:32 p.m. (2015-03-04 12:32:02 UTC) #17
mathias
Loosing overview is what happens when branches live too long.. ;) Seriously, starting over does ...
March 4, 2015, 12:32 p.m. (2015-03-04 12:32:36 UTC) #18
Felix Dahlke
Still have to take a closer look, but here's some more comments for now. http://codereview.adblockplus.org/4810150141493248/diff/5647308616105984/README.md ...
March 4, 2015, 2:27 p.m. (2015-03-04 14:27:53 UTC) #19
Wladimir Palant
http://codereview.adblockplus.org/4810150141493248/diff/5647308616105984/run.py File run.py (right): http://codereview.adblockplus.org/4810150141493248/diff/5647308616105984/run.py#newcode56 run.py:56: host_names = set(str(item) for item in hosts) On 2015/03/04 ...
March 4, 2015, 3:14 p.m. (2015-03-04 15:14:11 UTC) #20
mathias
March 4, 2015, 5:59 p.m. (2015-03-04 17:59:39 UTC) #21
Wladimir Palant
No further comments from my end. On 2015/03/04 12:32:36, matze wrote: > Loosing overview is ...
March 4, 2015, 6:08 p.m. (2015-03-04 18:08:26 UTC) #22
mathias
Well then, let's wait for Felix'. I also still need feedback on my suggestion above.. ...
March 4, 2015, 6:13 p.m. (2015-03-04 18:13:51 UTC) #23
Felix Dahlke
Alright, finally took a thorough look! It's almost there, mostly got nits about stuff I ...
March 9, 2015, 11:14 p.m. (2015-03-09 23:14:51 UTC) #24
mathias
March 16, 2015, 12:06 p.m. (2015-03-16 12:06:14 UTC) #25
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/README.md File README.md (right): http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/README.md#newcode22 README.md:22: defaults suitable for development and testing purpose. One can ...
March 16, 2015, 12:07 p.m. (2015-03-16 12:07:11 UTC) #26
mathias
March 16, 2015, 2:04 p.m. (2015-03-16 14:04:46 UTC) #27
Felix Dahlke
LGTM, assuming you answer "no" to my question. http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile File Vagrantfile (right): http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile#newcode28 Vagrantfile:28: setup ...
March 16, 2015, 6:10 p.m. (2015-03-16 18:10:14 UTC) #28
mathias
http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile File Vagrantfile (right): http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile#newcode28 Vagrantfile:28: setup = YAML.load_file(setup_path) rescue {} On 2015/03/16 18:10:15, Felix ...
March 16, 2015, 7:09 p.m. (2015-03-16 19:09:17 UTC) #29
Wladimir Palant
http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile File Vagrantfile (right): http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagrantfile#newcode28 Vagrantfile:28: setup = YAML.load_file(setup_path) rescue {} On 2015/03/16 18:10:15, Felix ...
March 16, 2015, 7:09 p.m. (2015-03-16 19:09:42 UTC) #30
Felix Dahlke
March 17, 2015, 3:48 a.m. (2015-03-17 03:48:24 UTC) #31
LGTM

http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagr...
File Vagrantfile (right):

http://codereview.adblockplus.org/4810150141493248/diff/5720605454237696/Vagr...
Vagrantfile:28: setup = YAML.load_file(setup_path) rescue {}
On 2015/03/16 19:09:42, Wladimir Palant wrote:
> On 2015/03/16 18:10:15, Felix H. Dahlke wrote:
> > But setup would be nill - can we call "fetch" on nil without exceptions?
> 
> As you said yourself, setup would be {} in case of an exception rather than
nil
> - and {}.fetch("requirements", {}) will give you  {}, all fine.

Right, missed that yesterday, works fine indeed.

Powered by Google App Engine
This is Rietveld