Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4811406654308352: Issue 763 - Count the number of users for the anti-adblock filters (Closed)

Created:
July 9, 2014, 1 p.m. by Wladimir Palant
Modified:
July 9, 2014, 3:14 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Issue 763 - Count the number of users for the anti-adblock filters

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M modules/statsmaster/files/usercounts.html View 5 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
July 9, 2014, 1 p.m. (2014-07-09 13:00:24 UTC) #1
mathias
July 9, 2014, 1:49 p.m. (2014-07-09 13:49:28 UTC) #2
The modifications look fine to me. You've even fixed a minor issue in the HTML
table implicitly.

Yet, I'm not sure whether the changes actually solve the issue - although it
seems so (from what I can tell already and guess in between).

LGTM

Powered by Google App Engine
This is Rietveld