Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 4812049892769792: Add acceptable ads message in FRP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by Oleksandr
Modified:
5 years, 3 months ago
Reviewers:
Felix Dahlke
CC:
sergei, Eric
Visibility:
Public.

Description

Add acceptable ads message in FRP

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't use innerHTML assignment + OCD stuff #

Total comments: 2

Patch Set 3 : Cosmetic fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M html/static/js/firstRun.js View 1 2 3 chunks +58 lines, -4 lines 0 comments Download
M html/templates/firstRun.html View 1 chunk +5 lines, -5 lines 0 comments Download
M locales/en.ini View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Oleksandr
5 years, 3 months ago (2014-07-24 07:49:13 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/4812049892769792/diff/5629499534213120/html/static/js/firstRun.js File html/static/js/firstRun.js (right): http://codereview.adblockplus.org/4812049892769792/diff/5629499534213120/html/static/js/firstRun.js#newcode111 html/static/js/firstRun.js:111: "aa-title": "first-run-aa-title", Being somewhat OCD again, but I think ...
5 years, 3 months ago (2014-07-24 08:04:22 UTC) #2
Oleksandr
5 years, 3 months ago (2014-07-24 09:00:45 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/4812049892769792/diff/5086100271923200/html/static/js/firstRun.js File html/static/js/firstRun.js (right): http://codereview.adblockplus.org/4812049892769792/diff/5086100271923200/html/static/js/firstRun.js#newcode139 html/static/js/firstRun.js:139: // Inserts i18n strings into matching elements. Any inner ...
5 years, 3 months ago (2014-07-24 09:04:49 UTC) #4
Oleksandr
5 years, 3 months ago (2014-07-24 09:14:23 UTC) #5
Felix Dahlke
5 years, 3 months ago (2014-07-24 09:20:45 UTC) #6
Wow, such cosmetics, very LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5