Issue 1777 - ensure_dependencies.py fails to detect unknown Git revisions

ensure_dependencies.py

Index: ensure_dependencies.py
===================================================================
--- a/ensure_dependencies.py
+++ b/ensure_dependencies.py
@@ -84,17 +84,17 @@ class Git():
 
   def clone(self, source, target):
     source = source.rstrip("/")
     if not source.endswith(".git"):
       source += ".git"
     subprocess.check_call(["git", "clone", "--quiet", source, target])
 
   def get_revision_id(self, repo, rev="HEAD"):
-    command = ["git", "rev-parse", "--revs-only", rev]
+    command = ["git", "rev-parse", "--revs-only", rev + '^{commit}']

[mathias, 2015/01/12 11:51:11]

What about ["git", "rev-parse", "--revs-only", "--verify", rev]?

[Wladimir Palant, 2015/01/12 12:50:05]

I tried it already, and couldn't see any real difference from specifying the
--verify option - non-existent revisions are still being accepted. Actually, I
found the hint to specifying the expected type explicitly in the documentation
for the --verify option.

     return subprocess.check_output(command, cwd=repo).strip()
 
   def pull(self, repo):
     subprocess.check_call(["git", "fetch", "--quiet", "--all", "--tags"], cwd=repo)
 
   def update(self, repo, rev):
     subprocess.check_call(["git", "checkout", "--quiet", rev], cwd=repo)