Issue 1777 - ensure_dependencies.py fails to detect unknown Git revisions

Issue 1777 - ensure_dependencies.py fails to detect unknown Git revisions

[Wladimir Palant, 2015-01-11 23:10:22]

http://codereview.adblockplus.org/4814432072892416/diff/5629499534213120/ensu...
File ensure_dependencies.py (right):

http://codereview.adblockplus.org/4814432072892416/diff/5629499534213120/ensu...
ensure_dependencies.py:92: command = ["git", "rev-list", "--remotes=*",
"--max-count=1", rev]
Note that I don't really know how to use Git, and its command line interface is
quite a mess. So far that's the only command I found that will resolve tags into
revision IDs, keep existing revision IDs unchanged and complain about
non-existing ones.

[Wladimir Palant, 2015-01-11 23:39:28]

http://codereview.adblockplus.org/4814432072892416/diff/5629499534213120/ensu...
File ensure_dependencies.py (right):

http://codereview.adblockplus.org/4814432072892416/diff/5629499534213120/ensu...
ensure_dependencies.py:92: command = ["git", "rev-list", "--remotes=*",
"--max-count=1", rev]
I noticed that the rev-list with --remotes specified will resolve HEAD
incorrectly (remote HEAD taken). On the other hand, without --remotes it will
refuse to work on fetched revisions above HEAD. It seems however that rev-parse
will produce the desired results if type is specified explicitly:
<rev>^{commit}. So I went with this solution now.

[Sebastian Noack, 2015-01-12 09:31:19]

LGTM

[mathias, 2015-01-12 11:51:11]

http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
File ensure_dependencies.py (right):

http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
ensure_dependencies.py:92: command = ["git", "rev-parse", "--revs-only", rev +
'^{commit}']
What about ["git", "rev-parse", "--revs-only", "--verify", rev]?

[Wladimir Palant, 2015-01-12 12:50:04]

http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
File ensure_dependencies.py (right):

http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
ensure_dependencies.py:92: command = ["git", "rev-parse", "--revs-only", rev +
'^{commit}']
On 2015/01/12 11:51:11, matze wrote:
> What about ["git", "rev-parse", "--revs-only", "--verify", rev]?

I tried it already, and couldn't see any real difference from specifying the
--verify option - non-existent revisions are still being accepted. Actually, I
found the hint to specifying the expected type explicitly in the documentation
for the --verify option.

[mathias, 2015-01-12 15:11:44]

On 2015/01/12 12:50:04, Wladimir Palant wrote:
>
http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
> File ensure_dependencies.py (right):
> 
>
http://codereview.adblockplus.org/4814432072892416/diff/5649050225344512/ensu...
> ensure_dependencies.py:92: command = ["git", "rev-parse", "--revs-only", rev +
> '^{commit}']
> On 2015/01/12 11:51:11, matze wrote:
> > What about ["git", "rev-parse", "--revs-only", "--verify", rev]?
> 
> I tried it already, and couldn't see any real difference from specifying the
> --verify option - non-existent revisions are still being accepted. Actually, I
> found the hint to specifying the expected type explicitly in the documentation
> for the --verify option.

LGTM,..
... and hank you for the clarification.