Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4848713646211072: Issue 537 - Consider changes made for marking first few downloads (Closed)

Nov. 11, 2014, 6:01 p.m. by Thomas Greiner
Nov. 12, 2014, 10:12 a.m.
Wladimir Palant


Note: Since downloadCount's initial value is zero and zeros are not being serialized, no changes to other files (subscriptionClasses.js and patterns.ini) had to be made.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/content/tests/notification.js View 2 chunks +2 lines, -2 lines 0 comments Download


Total messages: 2
Thomas Greiner
Nov. 11, 2014, 6:09 p.m. (2014-11-11 18:09:55 UTC) #1
Wladimir Palant
Nov. 11, 2014, 8:43 p.m. (2014-11-11 20:43:14 UTC) #2
These changes are sufficient to have the tests pass, but they don't actually
test the functionality. E.g. subscriptionClasses.js has to test whether the
downloadCount field is being serialized correctly. However, given that we
apparently don't test lastVersion properly either, feel free to file a follow-up
bug to fix that.


Powered by Google App Engine
This is Rietveld