Issue 4848713646211072: Issue 537 - Consider changes made for marking first few downloads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4848713646211072: Issue 537 - Consider changes made for marking first few downloads (Closed)

Created:
Nov. 11, 2014, 6:01 p.m. by Thomas Greiner

Modified:
Nov. 12, 2014, 10:12 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Note: Since downloadCount's initial value is zero and zeros are not being serialized, no changes to other files (subscriptionClasses.js and patterns.ini) had to be made.

Patch Set 1 #

Created: Nov. 11, 2014, 6:01 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/content/tests/notification.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

Nov. 11, 2014, 8:43 p.m. (2014-11-11 20:43:14 UTC) #2

These changes are sufficient to have the tests pass, but they don't actually
test the functionality. E.g. subscriptionClasses.js has to test whether the
downloadCount field is being serialized correctly. However, given that we
apparently don't test lastVersion properly either, feel free to file a follow-up
bug to fix that.

LGTM

Expand All Messages | Collapse All Messages