Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 4851712741343232: Issue 1451 - Redirect Android devbuild update requests for versions that crash when detecting an up… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by Felix Dahlke
Modified:
5 years, 4 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1451 - Redirect Android devbuild update requests for versions that crash when detecting an update

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check $arg_addonVersion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M modules/downloadserver/files/site.conf View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
5 years, 4 months ago (2014-09-27 20:57:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4851712741343232/diff/5629499534213120/modules/downloadserver/files/site.conf File modules/downloadserver/files/site.conf (right): http://codereview.adblockplus.org/4851712741343232/diff/5629499534213120/modules/downloadserver/files/site.conf#newcode27 modules/downloadserver/files/site.conf:27: if ($query_string ~ "addonVersion=1\.2\.1\.3\d\d\.3\d\d") Please check $arg_addonVersion here.
5 years, 4 months ago (2014-09-29 11:36:01 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/4851712741343232/diff/5629499534213120/modules/downloadserver/files/site.conf File modules/downloadserver/files/site.conf (right): http://codereview.adblockplus.org/4851712741343232/diff/5629499534213120/modules/downloadserver/files/site.conf#newcode27 modules/downloadserver/files/site.conf:27: if ($query_string ~ "addonVersion=1\.2\.1\.3\d\d\.3\d\d") On 2014/09/29 11:36:01, Wladimir Palant ...
5 years, 4 months ago (2014-09-29 11:49:15 UTC) #3
Wladimir Palant
5 years, 4 months ago (2014-09-29 11:51:24 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5