src/plugin/PluginUtil.h - Issue 4859310991474688: Issue 1681 - Incorrect usage of BString

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/plugin/PluginUtil.h

Issue 4859310991474688: Issue 1681 - Incorrect usage of BString (Closed)

Patch Set: Created Dec. 10, 2014, 11:34 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #pragma once	1 #pragma once

2 #include <string>	2 #include <string>

3	3

4 class BString

5 {

6 public:

7 BString(const std::wstring& value);

8 ~BString();

9 operator BSTR();

10 private:

11 BSTR value;

12 BString(const BString&);

13 BString& operator=(const BString&);

14 };

15

16 std::wstring HtmlFolderPath();	4 std::wstring HtmlFolderPath();

17 std::wstring UserSettingsFileUrl();	5 std::wstring UserSettingsFileUrl();

18 std::wstring FirstRunPageFileUrl();	6 std::wstring FirstRunPageFileUrl();

19 std::wstring FileUrl(const std::wstring& url);	7 std::wstring FileUrl(const std::wstring& url);

OLD	NEW