Issue 1681 - Incorrect usage of BString

# don't push until the upcoming release will be released.

[Oleksandr, 2014-12-11 10:47:03]

LGTM

[Eric, 2014-12-12 15:48:55]

Code LGTM.

I don't like the phrase "incorrect usage", though. The class 'BString' isn't so
much incorrect as redundant. I'd suggest a title "Removed redundant class
BString".

http://codereview.adblockplus.org/4859310991474688/diff/5629499534213120/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/4859310991474688/diff/5629499534213120/src/...
src/plugin/PluginClass.cpp:1235: ATL::CComBSTR
urlToNavigate(userSettingsFileUrl.length(), userSettingsFileUrl.c_str());
The CComBSTR constructor takes an ordinary signed 'int' here, which can generate
a spurious warning. (Perhaps not our default build warning level, but still ...)
I'd put an explicit cast in place to make the issue go away forever.

[sergei, 2014-12-12 15:52:55]

On 2014/12/12 15:48:55, Eric wrote:
> Code LGTM.
> 
> I don't like the phrase "incorrect usage", though. The class 'BString' isn't
so
> much incorrect as redundant. I'd suggest a title "Removed redundant class
> BString".
Class is correct although redundant but the usage is incorrect, see description
in the issue.
> 
>
http://codereview.adblockplus.org/4859310991474688/diff/5629499534213120/src/...
> File src/plugin/PluginClass.cpp (right):
> 
>
http://codereview.adblockplus.org/4859310991474688/diff/5629499534213120/src/...
> src/plugin/PluginClass.cpp:1235: ATL::CComBSTR
> urlToNavigate(userSettingsFileUrl.length(), userSettingsFileUrl.c_str());
> The CComBSTR constructor takes an ordinary signed 'int' here, which can
generate
> a spurious warning. (Perhaps not our default build warning level, but still
...)
> I'd put an explicit cast in place to make the issue go away forever.

[Eric, 2014-12-12 16:01:22]

On 2014/12/12 15:52:55, sergei wrote:
> Class is correct although redundant but the usage is incorrect, see
description
> in the issue.

Which issue? There's none linked in the description.

[Eric, 2014-12-12 16:02:51]

Patch LGTM.

[sergei, 2014-12-12 16:07:15]

On 2014/12/12 16:01:22, Eric wrote:
> On 2014/12/12 15:52:55, sergei wrote:
> > Class is correct although redundant but the usage is incorrect, see
> description
> > in the issue.
> 
> Which issue? There's none linked in the description.

It's before "Incorrect usage of BString", "Issue 4859310991474688: Issue 1681 -
Incorrect usage of BString", https://issues.adblockplus.org/ticket/1681