src/plugin/PluginClass.cpp - Issue 4859310991474688: Issue 1681 - Incorrect usage of BString

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginClass.cpp

Issue 4859310991474688: Issue 1681 - Incorrect usage of BString (Closed)

Patch Set: prevent warning of implicit conversion from std::wstring::size_type (size_t here) to signed int Created Dec. 12, 2014, 4:01 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/PluginClass.cpp

diff --git a/src/plugin/PluginClass.cpp b/src/plugin/PluginClass.cpp

index ec695ee2de3dbcf13be0979675f0e95a015dc82c..ead88dc2817b0c8ff814ddea3cf688d4d9496d48 100644

--- a/src/plugin/PluginClass.cpp

+++ b/src/plugin/PluginClass.cpp

@@ -1231,7 +1231,8 @@ void CPluginClass::DisplayPluginMenu(HMENU hMenu, int nToolbarCmdID, POINT pt, U

vFlags.vt = VT_I4;

vFlags.intVal = navOpenInNewTab;

- BSTR urlToNavigate = BString(UserSettingsFileUrl());

+ auto userSettingsFileUrl = UserSettingsFileUrl();

+ ATL::CComBSTR urlToNavigate(static_cast<int>(userSettingsFileUrl.length()), userSettingsFileUrl.c_str());

HRESULT hr = browser->Navigate(urlToNavigate, &vFlags, NULL, NULL, NULL);

if (FAILED(hr))

{

« no previous file with comments | « no previous file | src/plugin/PluginUtil.h » ('j') | no next file with comments »