Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4865772761382912: Issue 194 - Fixed: Removing elements from DOM can lead to JavaScript errors on page (Closed)

Created:
March 27, 2014, 11:41 a.m. by Thomas Greiner
Modified:
March 27, 2014, 11:54 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This fixes the issue mentioned at https://issues.adblockplus.org/ticket/194 which is caused by a JavaScript error being thrown due to the page trying to set the property of an iFrame that has already been removed by us.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include.preload.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Wladimir Palant
March 27, 2014, 11:49 a.m. (2014-03-27 11:49:53 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld