Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4870920422293504: Issue 1856 - Fall back to parent HTML element when "Block element" encounters an SVG element (Closed)

Created:
Jan. 23, 2015, 2:20 p.m. by Sebastian Noack
Modified:
Jan. 27, 2015, 10:50 a.m.
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1856 - Fall back to parent HTML element when "Block element" encounters an SVG element

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include.postload.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 23, 2015, 2:20 p.m. (2015-01-23 14:20:56 UTC) #1
kzar
Maybe we should check that the element is a SVGElement instead of that it isn't ...
Jan. 26, 2015, 3:31 p.m. (2015-01-26 15:31:08 UTC) #2
Sebastian Noack
On 2015/01/26 15:31:08, kzar wrote: > Maybe we should check that the element is a ...
Jan. 26, 2015, 3:41 p.m. (2015-01-26 15:41:53 UTC) #3
kzar
Jan. 26, 2015, 5:29 p.m. (2015-01-26 17:29:03 UTC) #4
Hmm good point, LGTM.

Powered by Google App Engine
This is Rietveld