Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4875173639487488: Optmize filter list in elemHide.js for memory usage (Closed)

Created:
April 4, 2014, 11:34 a.m. by tschuster
Modified:
Oct. 19, 2014, 9:50 p.m.
Visibility:
Public.

Description

Optmize filter list in elemHide.js for memory usage

Patch Set 1 #

Total comments: 3

Patch Set 2 : So I think I found a good solution. In filterListener.js we already have the concept of flushing el… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -26 lines) Patch
M lib/elemHide.js View 1 7 chunks +81 lines, -26 lines 0 comments Download
M lib/filterListener.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
tschuster
I found some issue. I hope we don't actually need to deduplicate. http://codereview.adblockplus.org/4875173639487488/diff/5629499534213120/lib/elemHide.js File lib/elemHide.js ...
April 4, 2014, 1:17 p.m. (2014-04-04 13:17:45 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/4875173639487488/diff/5629499534213120/lib/elemHide.js File lib/elemHide.js (right): http://codereview.adblockplus.org/4875173639487488/diff/5629499534213120/lib/elemHide.js#newcode161 lib/elemHide.js:161: filters[index] = undefined; // Indicates deleted. This won't work ...
April 8, 2014, 11:24 a.m. (2014-04-08 11:24:52 UTC) #2
tschuster
So I think I found a good solution. In filterListener.js we already have the concept ...
May 5, 2014, 3:47 p.m. (2014-05-05 15:47:32 UTC) #3
tschuster
Oct. 19, 2014, 9:50 p.m. (2014-10-19 21:50:06 UTC) #4
I don't think we really need this.

Powered by Google App Engine
This is Rietveld