Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4886747309670400: Noissue - Added documentation for exported functions to the "filterValidation" module (Closed)

Created:
Feb. 28, 2015, 5:47 p.m. by Sebastian Noack
Modified:
March 3, 2015, 9:38 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Noissue - Added documentation for exported functions to the "filterValidation" module

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M lib/filterValidation.js View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Feb. 28, 2015, 5:47 p.m. (2015-02-28 17:47:30 UTC) #1
kzar
LGTM
March 2, 2015, 5:13 p.m. (2015-03-02 17:13:55 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4886747309670400/diff/5629499534213120/lib/filterValidation.js File lib/filterValidation.js (right): http://codereview.adblockplus.org/4886747309670400/diff/5629499534213120/lib/filterValidation.js#newcode26 lib/filterValidation.js:26: * if a filter list header is given. I ...
March 2, 2015, 8:45 p.m. (2015-03-02 20:45:15 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/4886747309670400/diff/5629499534213120/lib/filterValidation.js File lib/filterValidation.js (right): http://codereview.adblockplus.org/4886747309670400/diff/5629499534213120/lib/filterValidation.js#newcode26 lib/filterValidation.js:26: * if a filter list header is given. On ...
March 3, 2015, 9:07 a.m. (2015-03-03 09:07:46 UTC) #4
Wladimir Palant
March 3, 2015, 9:27 a.m. (2015-03-03 09:27:09 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld