Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 4889997257736192: Issue 1821 - Add product support URL to installer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Oleksandr
Modified:
4 years, 8 months ago
Reviewers:
Eric, sergei
Visibility:
Public.

Description

Issue 1821 - Add product support URL to installer

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M installer/src/msi/adblockplusie.wxs View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Oleksandr
4 years, 11 months ago (2015-03-13 13:16:44 UTC) #1
Eric
Looks fine overall. http://codereview.adblockplus.org/4889997257736192/diff/5629499534213120/installer/src/msi/adblockplusie.wxs File installer/src/msi/adblockplusie.wxs (right): http://codereview.adblockplus.org/4889997257736192/diff/5629499534213120/installer/src/msi/adblockplusie.wxs#newcode154 installer/src/msi/adblockplusie.wxs:154: --> Can we kill this comment ...
4 years, 11 months ago (2015-03-13 16:37:11 UTC) #2
Oleksandr
http://codereview.adblockplus.org/4889997257736192/diff/5629499534213120/installer/src/msi/adblockplusie.wxs File installer/src/msi/adblockplusie.wxs (right): http://codereview.adblockplus.org/4889997257736192/diff/5629499534213120/installer/src/msi/adblockplusie.wxs#newcode159 installer/src/msi/adblockplusie.wxs:159: <Property Id="ARPHELPLINK" Value="https://adblockplus.org/en/bugs"/> On 2015/03/13 16:37:11, Eric wrote: > ...
4 years, 11 months ago (2015-03-20 04:44:33 UTC) #3
Eric
Patch set 2 LGTM.
4 years, 11 months ago (2015-03-20 12:14:19 UTC) #4
sergei
4 years, 11 months ago (2015-03-30 09:41:23 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5