Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4890865847762944: Issue 1739 - Respect MessageSender.frameId if available (Closed)

Created:
Dec. 28, 2014, 1:27 p.m. by Sebastian Noack
Modified:
Jan. 15, 2015, 12:39 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1739 - Respect MessageSender.frameId if available

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/ext/background.js View 1 chunk +14 lines, -3 lines 2 comments Download

Messages

Total messages: 6
Sebastian Noack
Dec. 28, 2014, 1:28 p.m. (2014-12-28 13:28:24 UTC) #1
kzar
http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js#newcode368 chrome/ext/background.js:368: else Maybe remove the else here? That way if ...
Jan. 5, 2015, 3:30 p.m. (2015-01-05 15:30:15 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js#newcode368 chrome/ext/background.js:368: else On 2015/01/05 15:30:15, kzar wrote: > Maybe remove ...
Jan. 5, 2015, 3:33 p.m. (2015-01-05 15:33:36 UTC) #3
kzar
On 2015/01/05 15:33:36, Sebastian Noack wrote: > http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js > File chrome/ext/background.js (right): > > http://codereview.adblockplus.org/4890865847762944/diff/5629499534213120/chrome/ext/background.js#newcode368 ...
Jan. 5, 2015, 3:34 p.m. (2015-01-05 15:34:28 UTC) #4
kzar
LGTM
Jan. 5, 2015, 3:34 p.m. (2015-01-05 15:34:42 UTC) #5
Wladimir Palant
Jan. 15, 2015, 12:39 p.m. (2015-01-15 12:39:09 UTC) #6
Belated LGTM, nice to see the APIs slowly recognize the existence of frames.

Powered by Google App Engine
This is Rietveld