Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4896746270359552: Bug 981543 - Don`t check whether our toolbar button has a context attribute (Closed)

Created:
March 11, 2014, 8:32 a.m. by Wladimir Palant
Modified:
March 11, 2014, 9:37 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

See https://bugzilla.mozilla.org/show_bug.cgi?id=981543 for the context. Quite frankly, I don`t remember what scenario this check is supposed to cover. Our toolbar button always has a context attribute so the check isn`t really necessary.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/ui.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
March 11, 2014, 8:32 a.m. (2014-03-11 08:32:26 UTC) #1
Thomas Greiner
March 11, 2014, 9:23 a.m. (2014-03-11 09:23:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld