Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/ui.js

Issue 4896746270359552: Bug 981543 - Don`t check whether our toolbar button has a context attribute (Closed)
Patch Set: Created March 11, 2014, 8:32 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/ui.js
===================================================================
--- a/lib/ui.js
+++ b/lib/ui.js
@@ -445,21 +445,21 @@ let UI = exports.UI =
if (action == "subscription.updated")
addAntiAdblockNotification(value);
else if (action == "subscription.removed" || (action == "subscription.disabled" && !value.disabled))
removeAntiAdblockNotification();
});
var documentCreationObserver = {
- observe: function(subject, topic, data)
+ observe: function(subject, topic, data)
{
if (!(subject instanceof Ci.nsIDOMWindow))
return;
-
+
this._showNextNotification(subject.location.href);
}.bind(this)
};
Services.obs.addObserver(documentCreationObserver, "content-document-global-created", false);
onShutdown.add(function()
{
Services.obs.removeObserver(documentCreationObserver, "content-document-global-created", false);
});
@@ -1126,17 +1126,17 @@ let UI = exports.UI =
{
if (Prefs.defaultstatusbaraction == 0)
icon.setAttribute("popup", icon.getAttribute("context"));
else
icon.removeAttribute("popup");
}
else
{
- if (icon.hasAttribute("context") && Prefs.defaulttoolbaraction == 0)
+ if (Prefs.defaulttoolbaraction == 0)
icon.setAttribute("type", "menu");
else
icon.setAttribute("type", "menu-button");
}
icon.setAttribute("abpstate", state);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld