Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 4899447913840640: Issue 1106 - Add currentVersion Pref and compareVersions API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Oleksandr
Modified:
5 years, 6 months ago
Visibility:
Public.

Description

Issue 1106 - Add currentVersion Pref and compareVersions API

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M include/AdblockPlus/FilterEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M lib/api.js View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/prefs.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/FilterEngine.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Oleksandr
5 years, 6 months ago (2014-08-01 12:52:38 UTC) #1
Felix Dahlke
LGTM
5 years, 6 months ago (2014-08-01 12:55:31 UTC) #2
Wladimir Palant
LGTM
5 years, 6 months ago (2014-08-01 13:04:07 UTC) #3
Felix Dahlke
5 years, 6 months ago (2014-08-01 13:09:20 UTC) #4
Note that I would vote for a different commit message here - it's required for
1106, but it's not fixing that issue.

I'd go with this as a commit message:

"
Add currentVersion Pref and compareVersions API

http://codereview.adblockplus.org/4899447913840640
"

Alternatively, feel free to create an issue for this that blocks 1106 - that'd
be the clean way :P
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5