Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(185)

Issue 4901331810648064: Issue 2309 - Reorder Known Issue Sentences in FF Issue Reporter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Wladimir Palant
Modified:
3 years, 7 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Normally, changing the template would be sufficient. However, testing locally was no longer possible due to multiplexer changes so CONTENT_LENGTH handling had to be fixed as well. Removed deprecated setupStderr call while at it.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M sitescripts/reports/template/submitSuccess.html View 1 chunk +7 lines, -3 lines 0 comments Download
M sitescripts/reports/web/submitReport.py View 1 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
4 years, 5 months ago (2015-04-13 21:57:43 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py File sitescripts/reports/web/submitReport.py (right): http://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py#newcode49 sitescripts/reports/web/submitReport.py:49: return showError('Invalid or missing Content-Length header', start_response) Status code ...
4 years, 5 months ago (2015-04-14 06:30:59 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py File sitescripts/reports/web/submitReport.py (right): https://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py#newcode49 sitescripts/reports/web/submitReport.py:49: return showError('Invalid or missing Content-Length header', start_response) On 2015/04/14 ...
3 years, 7 months ago (2016-02-10 15:43:43 UTC) #3
Sebastian Noack
3 years, 7 months ago (2016-02-10 15:45:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5