Issue 4901331810648064: Issue 2309 - Reorder Known Issue Sentences in FF Issue Reporter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4901331810648064: Issue 2309 - Reorder Known Issue Sentences in FF Issue Reporter (Closed)

Created:
April 13, 2015, 9:56 p.m. by Wladimir Palant

Modified:
Feb. 10, 2016, 4:01 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Normally, changing the template would be sufficient. However, testing locally was no longer possible due to multiplexer changes so CONTENT_LENGTH handling had to be fixed as well. Removed deprecated setupStderr call while at it.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Created: Feb. 10, 2016, 3:43 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	sitescripts/reports/template/submitSuccess.html	View		1 chunk	+7 lines, -3 lines	0 comments	Download
	M	sitescripts/reports/web/submitReport.py	View	1	2 chunks	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

http://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py File sitescripts/reports/web/submitReport.py (right): http://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py#newcode49 sitescripts/reports/web/submitReport.py:49: return showError('Invalid or missing Content-Length header', start_response) Status code ...

April 14, 2015, 6:30 a.m. (2015-04-14 06:30:59 UTC) #2

Wladimir Palant

https://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py File sitescripts/reports/web/submitReport.py (right): https://codereview.adblockplus.org/4901331810648064/diff/5629499534213120/sitescripts/reports/web/submitReport.py#newcode49 sitescripts/reports/web/submitReport.py:49: return showError('Invalid or missing Content-Length header', start_response) On 2015/04/14 ...

Feb. 10, 2016, 3:43 p.m. (2016-02-10 15:43:43 UTC) #3

LGTM

Expand All Messages | Collapse All Messages