Issue 1107.update1 - read Notification properties (title, message and type) on the fly

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 116 matching lines @@
   params.push_back(shared_from_this());
   JsValuePtr result = func->Call(params);
   return result->AsBool();
 }
 
 bool Subscription::operator==(const Subscription& subscription) const
 {
   return GetProperty("url")->AsString() == subscription.GetProperty("url")->AsString();
 }
 
-FilterEngine::FilterEngine(JsEnginePtr jsEngine)
+FilterEngine::FilterEngine(JsEnginePtr jsEngine, 
+                           const FilterEngine::Prefs& preconfiguredPrefs)
     : jsEngine(jsEngine), initialized(false), firstRun(false), updateCheckId(0)
 {
-  jsEngine->SetEventCallback("init", std::tr1::bind(&FilterEngine::InitDone,
-      this, std::tr1::placeholders::_1));
+  jsEngine->SetEventCallback("_init", std::bind(&FilterEngine::InitDone,
+      this, std::placeholders::_1));
 
   {
     // Lock the JS engine while we are loading scripts, no timeouts should fire
     // until we are done.
     const JsContext context(jsEngine);
+
+    // Set the preconfigured prefs
+    JsValuePtr preconfiguredPrefsObject = jsEngine->NewObject();
+    for (FilterEngine::Prefs::const_iterator it = preconfiguredPrefs.begin();
+         it != preconfiguredPrefs.end(); it++)
+    {
+      preconfiguredPrefsObject->SetProperty(it->first, it->second);
+    }
+    jsEngine->SetGlobalProperty("_preconfiguredPrefs", preconfiguredPrefsObject);
+    // Load adblockplus scripts
     for (int i = 0; !jsSources[i].empty(); i += 2)
       jsEngine->Evaluate(jsSources[i + 1], jsSources[i]);
   }
 
   // TODO: This should really be implemented via a conditional variable
   while (!initialized)
     ::Sleep(10);
 }
 
 namespace
@@ skipping 37 matching lines @@
        it != contentTypes.end(); it++)
   {
     if (it->second == contentTypeUpper)
       return it->first;
   }
   throw std::invalid_argument("Cannot convert argument to ContentType");
 }
 
 void FilterEngine::InitDone(JsValueList& params)
 {
-  jsEngine->RemoveEventCallback("init");
+  jsEngine->RemoveEventCallback("_init");
   initialized = true;
   firstRun = params.size() && params[0]->AsBool();
 }
 
 bool FilterEngine::IsFirstRun() const
 {
   return firstRun;
 }
 
 FilterPtr FilterEngine::GetFilter(const std::string& text)
@@ skipping 35 matching lines @@
 std::vector<SubscriptionPtr> FilterEngine::FetchAvailableSubscriptions() const
 {
   JsValuePtr func = jsEngine->Evaluate("API.getRecommendedSubscriptions");
   JsValueList values = func->Call()->AsList();
   std::vector<SubscriptionPtr> result;
   for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
     result.push_back(SubscriptionPtr(new Subscription(*it)));
   return result;
 }
 
-NotificationPtr FilterEngine::GetNextNotificationToShow(const std::string& url)
-{
-  JsValuePtr func = jsEngine->Evaluate("API.getNextNotificationToShow");
+void FilterEngine::ShowNextNotification(const std::string& url)
+{
+  JsValuePtr func = jsEngine->Evaluate("API.showNextNotification");
   JsValueList params;
   if (!url.empty())
   {
     params.push_back(jsEngine->NewValue(url));
   }
-  auto jsNotification = func->Call(params);

[Felix Dahlke, 2015/01/27 13:09:09]

C++03! :)

[sergei, 2015/01/27 13:20:12]

fixed, sorry

-  if (!jsNotification->IsObject())
-  {
-    return NotificationPtr();
-  }
-  return NotificationPtr(new Notification(jsNotification));
+  func->Call(params);
+}
+
+void FilterEngine::SetShowNotificationCallback(const ShowNotificationCallback& value)
+{
+  if (!value)
+    return;
+
+  jsEngine->SetEventCallback("_showNotification",
+    std::bind(&FilterEngine::ShowNotification, this, value,
+              std::placeholders::_1));
+}
+
+void FilterEngine::RemoveShowNotificationCallback()
+{
+  jsEngine->RemoveEventCallback("_showNotification");
 }
 
 AdblockPlus::FilterPtr FilterEngine::Matches(const std::string& url,
     ContentType contentType,
     const std::string& documentUrl) const
 {
   std::vector<std::string> documentUrls;
   documentUrls.push_back(documentUrl);
   return Matches(url, contentType, documentUrls);
 }
@@ skipping 70 matching lines @@
   JsValuePtr func = jsEngine->Evaluate("API.getHostFromUrl");
   JsValueList params;
   params.push_back(jsEngine->NewValue(url));
   return func->Call(params)->AsString();
 }
 
 void FilterEngine::SetUpdateAvailableCallback(
     FilterEngine::UpdateAvailableCallback callback)
 {
   jsEngine->SetEventCallback("updateAvailable",
-      std::tr1::bind(&FilterEngine::UpdateAvailable, this, callback,
-                     std::tr1::placeholders::_1));
+      std::bind(&FilterEngine::UpdateAvailable, this, callback,
+                std::placeholders::_1));
 }
 
 void FilterEngine::RemoveUpdateAvailableCallback()
 {
   jsEngine->RemoveEventCallback("updateAvailable");
 }
 
 void FilterEngine::UpdateAvailable(
     FilterEngine::UpdateAvailableCallback callback, JsValueList& params)
 {
   if (params.size() >= 1 && !params[0]->IsNull())
     callback(params[0]->AsString());
 }
 
 void FilterEngine::ForceUpdateCheck(
     FilterEngine::UpdateCheckDoneCallback callback)
 {
-  std::string eventName = "updateCheckDone";
+  std::string eventName = "_updateCheckDone";
   eventName += ++updateCheckId;
 
-  jsEngine->SetEventCallback(eventName, std::tr1::bind(&FilterEngine::UpdateCheckDone,
-      this, eventName, callback, std::tr1::placeholders::_1));
+  jsEngine->SetEventCallback(eventName, std::bind(&FilterEngine::UpdateCheckDone,
+      this, eventName, callback, std::placeholders::_1));
 
   JsValuePtr func = jsEngine->Evaluate("API.forceUpdateCheck");
   JsValueList params;
   params.push_back(jsEngine->NewValue(eventName));
   func->Call(params);
 }
 
 void FilterEngine::UpdateCheckDone(const std::string& eventName,
     FilterEngine::UpdateCheckDoneCallback callback, JsValueList& params)
 {
   jsEngine->RemoveEventCallback(eventName);
 
   std::string error(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsString() : "");
   callback(error);
 }
 
 void FilterEngine::SetFilterChangeCallback(FilterEngine::FilterChangeCallback callback)
 {
-  jsEngine->SetEventCallback("filterChange", std::tr1::bind(&FilterEngine::FilterChanged,
-      this, callback, std::tr1::placeholders::_1));
+  jsEngine->SetEventCallback("filterChange", std::bind(&FilterEngine::FilterChanged,
+      this, callback, std::placeholders::_1));
 }
 
 void FilterEngine::RemoveFilterChangeCallback()
 {
   jsEngine->RemoveEventCallback("filterChange");
 }
 
 void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, JsValueList& params)
 {
   std::string action(params.size() >= 1 && !params[0]->IsNull() ? params[0]->AsString() : "");
   JsValuePtr item(params.size() >= 2 ? params[1] : jsEngine->NewValue(false));
   callback(action, item);
 }
+
+void FilterEngine::ShowNotification(const ShowNotificationCallback& callback,
+                                         const JsValueList& params)
+{
+  if (params.size() < 1)
+    return;
+
+  if (!params[0]->IsObject())
+  {
+    return;
+  }
+  callback(NotificationPtr(new Notification(params[0])));
+}
+
 
 int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2)
 {
   JsValueList params;
   params.push_back(jsEngine->NewValue(v1));
   params.push_back(jsEngine->NewValue(v2));
   JsValuePtr func = jsEngine->Evaluate("API.compareVersions");
   return func->Call(params)->AsInt();
 }