Issue 1107.update1 - read Notification properties (title, message and type) on the fly

[Felix Dahlke, 2015-01-27 13:09:08]

Looks good, but please add Wladimir as a reviewer since he had reservations
about this approach. I do prefer it: It allows us to get rid of that static
creation method and I don't see any downsides (GetTexts() should be called quite
rarely, and once for each Notification object, anyway).

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/incl...
File include/AdblockPlus/Notification.h (right):

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/incl...
include/AdblockPlus/Notification.h:51: class Notification: public JsValue,
public std::tr1::enable_shared_from_this<Notification>
Missed it before, but we have one space before `:` generally.

Note that it wouldn't hurt to wrap this to comply with the 80 column rule:

  class Notification
    : public JsValue, public std::tr1::enable_shared_from_this<Notification>

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/src/...
File src/FilterEngine.cpp (right):

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/src/...
src/FilterEngine.cpp:268: auto jsNotification = func->Call(params);
C++03! :)

[sergei, 2015-01-27 13:20:12]

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/incl...
File include/AdblockPlus/Notification.h (right):

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/incl...
include/AdblockPlus/Notification.h:51: class Notification: public JsValue,
public std::tr1::enable_shared_from_this<Notification>
On 2015/01/27 13:09:09, Felix H. Dahlke wrote:
> Missed it before, but we have one space before `:` generally.
> 
> Note that it wouldn't hurt to wrap this to comply with the 80 column rule:
> 
>   class Notification
>     : public JsValue, public std::tr1::enable_shared_from_this<Notification>

fixed. I styled it as Filter and Subscription in FilterEngine.h

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/src/...
File src/FilterEngine.cpp (right):

http://codereview.adblockplus.org/4904655779790848/diff/5629499534213120/src/...
src/FilterEngine.cpp:268: auto jsNotification = func->Call(params);
On 2015/01/27 13:09:09, Felix H. Dahlke wrote:
> C++03! :)

fixed, sorry

[Felix Dahlke, 2015-01-27 13:43:54]

LGTM

[Felix Dahlke, 2015-10-29 14:35:16]

Seeing how it has been 9 months, I guess you can move Wladimir to CC :)

Probably needs rebasing now though.

[Wladimir Palant, 2015-10-29 18:27:26]

LGTM

[sergei, 2015-11-04 09:25:16]

rebased

[Felix Dahlke, 2015-11-04 21:38:37]

Still LGTM.