Unified Diff: src/FilterEngine.cpp
Issue 4904655779790848:
Issue 1107.update1 - read Notification properties (title, message and type) on the fly (Closed)
Patch Set: rebase
Created Nov. 4, 2015, 9:22 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« include/AdblockPlus/Notification.h ('k')
|
src/Notification.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/FilterEngine.cpp |
| diff --git a/src/FilterEngine.cpp b/src/FilterEngine.cpp |
| index eed08b9a8c467749609a0e63186ab603fec66eda..0acb34b3860d6e8e56604ccd0c2b0ff45f6ef77d 100644 |
| --- a/src/FilterEngine.cpp |
| +++ b/src/FilterEngine.cpp |
| @@ -446,7 +446,11 @@ void FilterEngine::ShowNotification(const ShowNotificationCallback& callback, |
| if (params.size() < 1) |
| return; |
| - callback(Notification::JsValueToNotification(params[0])); |
| + if (!params[0]->IsObject()) |
| + { |
| + return; |
| + } |
| + callback(NotificationPtr(new Notification(params[0]))); |
| } |
« no previous file with comments
|
« include/AdblockPlus/Notification.h ('k')
|
src/Notification.cpp » ('j')
|
no next file with comments »
