deployments.html - Issue 4917771620057088: Issue 1505 - "Large Scale Deployments" section on adblockplus.org

Delta Between Two Patch Sets: deployments.html

Issue 4917771620057088: Issue 1505 - "Large Scale Deployments" section on adblockplus.org (Closed)

Left Patch Set: Created Nov. 3, 2014, 11:12 a.m.

Right Patch Set: Created Nov. 4, 2014, 11:22 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <p>Adblock Plus is a great asset to every company, university or large IT infras tructure containing multiple working stations.</p>	1 <p>Adblock Plus is a great asset to every company, university or large IT infras tructure containing multiple working stations.</p>

2 <p>How does Adblock Plus benefit you?</p>	2 <p>How does Adblock Plus benefit you?</p>

3 <ul>	3 <ul>

4 <li>	4 <li>

5 Considerably decreased privacy and security risks	5 Considerably decreased privacy and security risks

6 </li>	6 </li>

7 <li>	7 <li>

8 A better browsing experience for your users – no distractions from annoying pop-ups, blinking banners and video ads	8 A better browsing experience for your users – no distractions from annoying pop-ups, blinking banners and video ads

9 </li>	9 </li>

10 <li>	10 <li>

11 It’s FREE.	11 It's FREE
Thomas Greiner 2014/11/03 17:32:18 When copy-pasting something from a document please When copy-pasting something from a document please make sure you're not including characters like ’ „ or “. Instead use ' and ". Thomas Greiner 2014/11/03 17:32:18 It's inconsistent to have a "." at the end here bu It's inconsistent to have a "." at the end here but in none of the other bullet points. saroyanm 2014/11/03 18:17:57 Done. Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > When copy-pasting something from a document please make sure you're not > including characters like ’ „ or “. Instead use ' and ". Done. saroyanm 2014/11/03 18:17:57 Done. Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > It's inconsistent to have a "." at the end here but in none of the other bullet > points. Done.
12 </li>	12 </li>

13 </ul>	13 </ul>

14 <p>We are happy to help you deploy it over your entire network! Please contact u s at:<br/><a href="mailto:info@eyeo.com">deployment-support@adblockplus.org</a>< /p>	14 <p>We are happy to help you deploy it over your entire network! Please contact u s at: <a href="mailto:deployment-support@adblockplus.org" style="white-space: no wrap;">deployment-support@adblockplus.org</a></p>
Thomas Greiner 2014/11/03 17:32:18 The link's href and content do not match. The link's href and content do not match. Thomas Greiner 2014/11/03 17:32:18 Is this line meant to break here? It might look so Is this line meant to break here? It might look so in the text document but it doesn't have one. saroyanm 2014/11/03 18:17:57 Oooopsss.. Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > The link's href and content do not match. Oooopsss.. saroyanm 2014/11/03 18:17:57 Yes I used break here, because it was breaking aft Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > Is this line meant to break here? It might look so in the text document but it > doesn't have one. Yes I used break here, because it was breaking after "-" sign. So in the live example it will look like this: deployment- support@adblockplus.org Thomas Greiner 2014/11/04 10:19:36 Remember that this site will be translated into ot Show quoted text On 2014/11/03 18:17:57, saroyanm wrote: > On 2014/11/03 17:32:18, Thomas Greiner wrote: > > Is this line meant to break here? It might look so in the text document but it > > doesn't have one. > > Yes I used break here, because it was breaking after "-" sign. > So in the live example it will look like this: > deployment- > mailto:support@adblockplus.org Remember that this site will be translated into other languages. Therefore how about specifying its style as "white-space: nowrap" instead? This would allow it to stay on the same line as long as there's space for the entire email address and otherwise move to a new line. saroyanm 2014/11/04 11:25:12 Good point. Show quoted text On 2014/11/04 10:19:36, Thomas Greiner wrote: > On 2014/11/03 18:17:57, saroyanm wrote: > > On 2014/11/03 17:32:18, Thomas Greiner wrote: > > > Is this line meant to break here? It might look so in the text document but > it > > > doesn't have one. > > > > Yes I used break here, because it was breaking after "-" sign. > > So in the live example it will look like this: > > deployment- > > mailto:support@adblockplus.org > > Remember that this site will be translated into other languages. Therefore how > about specifying its style as "white-space: nowrap" instead? This would allow it > to stay on the same line as long as there's space for the entire email address > and otherwise move to a new line. Good point.
15 <p>Already deployed Adblock Plus? How was the experience? What can we do better? <a href="mailto:info@eyeo.com">Let us know!</a></p>	15 <p>Already deployed Adblock Plus? How was the experience? What can we do better? <a href="mailto:deployment-support@adblockplus.org">Let us know!</a></p>
Thomas Greiner 2014/11/03 17:32:18 This should link to "mailto:deployment-support@adb This should link to "mailto:deployment-support@adblockplus.org". saroyanm 2014/11/03 18:17:57 Oooopsss.. Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > This should link to "mailto:deployment-support@adblockplus.org". Oooopsss..
16 <p><a href="https://adblockplus.org/forum/viewtopic.php?f=21&t=24653&sid=db46979 e2327f9f608b4a4945fe5dd6d">More about the project</a></p>	16 <p><a href="https://adblockplus.org/forum/viewtopic.php?f=21&t=24653">More about the project</a></p>
Thomas Greiner 2014/11/03 17:32:18 No need to include the session ID in the link. No need to include the session ID in the link. saroyanm 2014/11/03 18:17:57 ouch. Show quoted text On 2014/11/03 17:32:18, Thomas Greiner wrote: > No need to include the session ID in the link. ouch.
LEFT	RIGHT