Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4917771620057088: Issue 1505 - "Large Scale Deployments" section on adblockplus.org (Closed)

Created:
Nov. 3, 2014, 11:12 a.m. by saroyanm
Modified:
Nov. 5, 2014, 3 p.m.
Reviewers:
Thomas Greiner
CC:
Felix Dahlke
Visibility:
Public.

Description

Ticket: https://issues.adblockplus.org/ticket/1505 Note: the title of Deployments page is "Large Scale Deployments".

Patch Set 1 #

Total comments: 14

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A deployments.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M footer.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
saroyanm
@Thomas can you please have a look when you will have time. Note: the title ...
Nov. 3, 2014, 11:16 a.m. (2014-11-03 11:16:57 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html File deployments.html (right): http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html#newcode11 deployments.html:11: It’s FREE. When copy-pasting something from a document please ...
Nov. 3, 2014, 5:32 p.m. (2014-11-03 17:32:18 UTC) #2
Thomas Greiner
On 2014/11/03 11:16:57, saroyanm wrote: > Note: the title of Deployments page is "Large Scale ...
Nov. 3, 2014, 5:34 p.m. (2014-11-03 17:34:36 UTC) #3
saroyanm
Result of sleeplessness :/ http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html File deployments.html (right): http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html#newcode11 deployments.html:11: It’s FREE. On 2014/11/03 17:32:18, ...
Nov. 3, 2014, 6:17 p.m. (2014-11-03 18:17:57 UTC) #4
Thomas Greiner
http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html File deployments.html (right): http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html#newcode14 deployments.html:14: <p>We are happy to help you deploy it over ...
Nov. 4, 2014, 10:19 a.m. (2014-11-04 10:19:36 UTC) #5
saroyanm
Done. http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html File deployments.html (right): http://codereview.adblockplus.org/4917771620057088/diff/5629499534213120/deployments.html#newcode14 deployments.html:14: <p>We are happy to help you deploy it ...
Nov. 4, 2014, 11:25 a.m. (2014-11-04 11:25:12 UTC) #6
Thomas Greiner
Nov. 4, 2014, 2:40 p.m. (2014-11-04 14:40:59 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld