Issue 2179 - [cms] Give Jinja2 templates a way to set global parameters

Issue 2179 - [cms] Give Jinja2 templates a way to set global parameters

[Sebastian Noack, 2015-03-20 09:44:35]

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
File cms/converters.py (right):

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
cms/converters.py:297: return template.render(self._params, params=self._params)
Note that modifying the params dict won't modify the current context. Hence
following template would output the old "title" passed to the template if any.

  {% do params.update(title="foo") %}
  ...
  {{ title }}

So how about:

  module = template.make_module(self._params)
  for key, value in module.__dict__.iteritems():
    if not key.startswith("_"):
      self._params[key] = value
  return unicode(module)

That way you can just keep using the regular {% set %} statement to set
variables. And variables set in the template will be copied to the self._params.

[Wladimir Palant, 2015-03-20 15:31:39]

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
File cms/converters.py (right):

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
cms/converters.py:297: return template.render(self._params, params=self._params)
On 2015/03/20 09:44:36, Sebastian Noack wrote:
> So how about:
> 
>   module = template.make_module(self._params)
>   for key, value in module.__dict__.iteritems():
>     if not key.startswith("_"):
>       self._params[key] = value
>   return unicode(module)
> 
> That way you can just keep using the regular {% set %} statement to set
> variables. And variables set in the template will be copied to the
self._params.

The complication here: only variables set at top level will work. So setting
conditionally for example is extremely awkward. But - fine with me, I managed to
get it working.

I'm somewhat concerned about dumping every exported variable into self._params
but I don't see a better solution right now.

[Sebastian Noack, 2015-03-20 15:53:18]

LGTM. Don't forget to update the issue description as well.

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
File cms/converters.py (right):

http://codereview.adblockplus.org/4923768585584640/diff/5741031244955648/cms/...
cms/converters.py:297: return template.render(self._params, params=self._params)
On 2015/03/20 15:31:39, Wladimir Palant wrote:
> On 2015/03/20 09:44:36, Sebastian Noack wrote:
> > So how about:
> > 
> >   module = template.make_module(self._params)
> >   for key, value in module.__dict__.iteritems():
> >     if not key.startswith("_"):
> >       self._params[key] = value
> >   return unicode(module)
> > 
> > That way you can just keep using the regular {% set %} statement to set
> > variables. And variables set in the template will be copied to the
> self._params.
> 
> The complication here: only variables set at top level will work. So setting
> conditionally for example is extremely awkward. But - fine with me, I managed
to
> get it working.
> 
> I'm somewhat concerned about dumping every exported variable into self._params
> but I don't see a better solution right now.

I think it's the best we can realistically do.