Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4935066966818816: Issue 1772 - [JSHydra] Convert const to var for Chrome (Closed)

Created:
Jan. 10, 2015, 12:03 a.m. by Wladimir Palant
Modified:
Jan. 10, 2015, 4:21 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 1772 - [JSHydra] Convert const to var for Chrome

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M autotest/abprewrite_source.js View 2 chunks +2 lines, -1 line 0 comments Download
M autotest/test_abprewrite.js.expected View 1 chunk +2 lines, -1 line 0 comments Download
M autotest/test_abprewrite_module.js.expected View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/abprewrite.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Jan. 10, 2015, 12:03 a.m. (2015-01-10 00:03:33 UTC) #1
Sebastian Noack
LGTM
Jan. 10, 2015, 8:25 a.m. (2015-01-10 08:25:36 UTC) #2
Sebastian Noack
I just realized that all Chrome (and Safari) version we care about already support "const" ...
Jan. 10, 2015, 11:17 a.m. (2015-01-10 11:17:32 UTC) #3
Wladimir Palant
Jan. 10, 2015, 4:21 p.m. (2015-01-10 16:21:33 UTC) #4
On 2015/01/10 11:17:32, Sebastian Noack wrote:
> I just realized that all Chrome (and Safari) version we care about already
> support "const" declaration:
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...

They do, and we didn't have any issues with that before. However, recent Chrome
versions started flagging const declarations when "use strict" is specified -
and we have that in typed objects code.

Powered by Google App Engine
This is Rietveld