Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4964592316841984: Issue 2041 - Filter Preferences: Findbar not fully functional in Firefox 36 (Closed)

Created:
Feb. 25, 2015, 5:08 p.m. by Wladimir Palant
Modified:
Feb. 27, 2015, 5:04 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

I also removed some backwards compatibility code. Note that the comment is wrong - the findbar API changed with https://bugzilla.mozilla.org/show_bug.cgi?id=666816 and that one landed in Firefox 26.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -67 lines) Patch
M chrome/content/ui/filters-search.js View 2 chunks +14 lines, -62 lines 2 comments Download
M metadata.gecko View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 25, 2015, 5:08 p.m. (2015-02-25 17:08:56 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/4964592316841984/diff/5629499534213120/chrome/content/ui/filters-search.js File chrome/content/ui/filters-search.js (left): http://codereview.adblockplus.org/4964592316841984/diff/5629499534213120/chrome/content/ui/filters-search.js#oldcode211 chrome/content/ui/filters-search.js:211: // This was used before Firefox 27 instead of ...
Feb. 27, 2015, 3:57 p.m. (2015-02-27 15:57:45 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/4964592316841984/diff/5629499534213120/chrome/content/ui/filters-search.js File chrome/content/ui/filters-search.js (left): http://codereview.adblockplus.org/4964592316841984/diff/5629499534213120/chrome/content/ui/filters-search.js#oldcode211 chrome/content/ui/filters-search.js:211: // This was used before Firefox 27 instead of ...
Feb. 27, 2015, 4:20 p.m. (2015-02-27 16:20:53 UTC) #3
Thomas Greiner
Feb. 27, 2015, 4:28 p.m. (2015-02-27 16:28:50 UTC) #4
Sorry, my bad
LGTM

Powered by Google App Engine
This is Rietveld